Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] US admin level 4 boundary lines appear incomplete #742

Open
danw-mpl opened this issue Dec 6, 2023 · 3 comments
Open

[BUG] US admin level 4 boundary lines appear incomplete #742

danw-mpl opened this issue Dec 6, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@danw-mpl
Copy link

danw-mpl commented Dec 6, 2023

Describe the bug
I can't figure out why US admin level 4 boundary lines appear incomplete? Is this an issue with Planetiler or the source OSM data?

To Reproduce
Use a custom YAML schema. The problem happens with and without tile post processing, and is consistent with zoom levels.

schema_name: My Schema
schema_description: v0.1.2
attribution: <a href="https://www.openstreetmap.org/copyright" target="_blank">&copy; OpenStreetMap contributors</a>
sources:
  osm:
    type: osm
    url: '${ args.osm_url }'

layers:
- id: admin_boundaries
  features:
  - source: osm
    geometry: line
    min_size: 0
    min_zoom: 3
    include_when:
      __all__:
      - boundary: administrative
      - admin_level: [ 3, 4 ]
    attributes:
    - key: maritime
      type: boolean
    - key: admin_level
      type: integer
  tile_post_process:
    merge_line_strings:
      min_length: 1
      tolerance: 1
      buffer: 5

Expected behavior
The admin 4 lines should be complete.

Screenshots
Screenshot 2023-12-06 at 12 06 00

Environment (please complete the following information):
Docker-based Planetiler (ghcr.io/onthegomap/planetiler:0.7.0)

@danw-mpl danw-mpl added the bug Something isn't working label Dec 6, 2023
@msbarry
Copy link
Contributor

msbarry commented Dec 6, 2023

Very strange... What osm url are you running with?

@msbarry
Copy link
Contributor

msbarry commented Dec 6, 2023

Ahh also one issue is that boundary ways get their admin level from relations since they may be the border of many admin regions at different levels. For example: https://www.openstreetmap.org/way/816355261.

Unfortunately yaml schemas don't support relations yet, planned in #351

@danw-mpl
Copy link
Author

danw-mpl commented Dec 6, 2023

Gotcha, so a simple workaround could likely be including other admin areas?

Alternatively I was going to try getting the states as polygons from OSM places.

My source is aws:latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants