Commit e5eb966
Improve arch diff dtype reporting and Gemma4 test coverage (#273)
## Changes
### Graph diff improvements (`_graph_diff.py`)
- **Interface change details**: Show dtype and shape specifics instead
of generic 'input[N] changed'. Example: `input[3]: dtype BOOL → FLOAT;
shape [?, 1, ?, ?] → [?, ?]`
- **Initializer dtype distribution**: Show per-dtype count changes
instead of just total count. Example: `FLOAT16: 42 → 38, FLOAT: 0 → 4` —
makes it easy to spot when a PR changes the compute precision of
weights.
### Test config improvements (`_test_configs.py`)
- Add `sliding_window=8` to both `gemma4_text` and `gemma4` multimodal
test configs. This exercises the sliding window mask generation path in
L1 tests, which was previously untested by the parametrized suite.
### Testing
- 2724 tests pass, 0 failures
- All 15 Gemma4 tests pass
- All 27 graph diff tests pass
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 2183a84 commit e5eb966
2 files changed
Lines changed: 35 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
191 | 191 | | |
192 | 192 | | |
193 | 193 | | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
194 | 206 | | |
195 | 207 | | |
196 | 208 | | |
| |||
217 | 229 | | |
218 | 230 | | |
219 | 231 | | |
220 | | - | |
| 232 | + | |
| 233 | + | |
221 | 234 | | |
222 | 235 | | |
223 | | - | |
| 236 | + | |
| 237 | + | |
224 | 238 | | |
225 | 239 | | |
226 | 240 | | |
| |||
232 | 246 | | |
233 | 247 | | |
234 | 248 | | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
235 | 265 | | |
236 | 266 | | |
237 | 267 | | |
238 | | - | |
| 268 | + | |
239 | 269 | | |
240 | 270 | | |
241 | 271 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
326 | 326 | | |
327 | 327 | | |
328 | 328 | | |
| 329 | + | |
329 | 330 | | |
330 | 331 | | |
331 | 332 | | |
| |||
2055 | 2056 | | |
2056 | 2057 | | |
2057 | 2058 | | |
| 2059 | + | |
2058 | 2060 | | |
2059 | 2061 | | |
2060 | 2062 | | |
| |||
0 commit comments