Skip to content

Commit 34e0cba

Browse files
justinchubyCopilot
andcommitted
docs: simplify f32 casting section — remove migration table
Remove per-task migration status table. The section now explains the general principle concisely without listing internal task status. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Justin Chu <justinchu@microsoft.com>
1 parent 8339d93 commit 34e0cba

1 file changed

Lines changed: 1 addition & 38 deletions

File tree

  • .agents/skills/multimodal-models

.agents/skills/multimodal-models/SKILL.md

Lines changed: 1 addition & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -279,44 +279,7 @@ Type Error: Type parameter (T) bound to different types
279279

280280
If you're adding a new multimodal model, you don't need to handle this
281281
manually — mobius inserts the Cast automatically for all encoder graphs.
282-
283-
### Task migration status
284-
285-
Tasks that handle encoder inputs fall into three categories:
286-
287-
**✅ f32 input + Cast pattern (correct):**
288-
289-
| Task | Encoder inputs |
290-
|------|---------------|
291-
| `Gemma4Task` | vision `pixel_values`, audio `input_features` |
292-
| `Phi4mmMultimodalTask` | vision `pixel_values`, audio `audio_embeds` |
293-
| `VisionLanguage3ModelTask` | vision `pixel_values` |
294-
| `SpeechLanguageTask` | audio `input_features` |
295-
| `FunAsrSpeechLanguageTask` | audio `input_features` |
296-
297-
These accept f32 inputs and `Cast(to=config.dtype)` at graph entry.
298-
299-
**⚠️ Needs migration (uses `config.dtype` as input dtype):**
300-
301-
| Task | Input | Issue |
302-
|------|-------|-------|
303-
| `VisionLanguageTask` | `pixel_values` | Uses `dtype=config.dtype` — should be f32 + Cast |
304-
| `MultimodalTask` | `pixel_values`, `audio_features` | Uses `dtype=config.dtype` — should be f32 + Cast |
305-
| `AudioCTCTask` | `input_features` | Uses `config.dtype or FLOAT` — should always be f32 + Cast |
306-
307-
**✅ Single-model tasks (hardcoded FLOAT — correct):**
308-
309-
| Task | Notes |
310-
|------|-------|
311-
| `ImageClassificationTask` | Single-model, f32 input is correct |
312-
| `AudioFeatureExtractionTask` | Single-model, f32 input is correct |
313-
| `CodecTask` | Single-model, f32 waveform input |
314-
| `QwenImageVAETask` | Single-model, f32 input |
315-
| `ObjectDetectionTask` | Single-model, f32 input |
316-
317-
Single-model tasks don't need the Cast pattern because they're
318-
standalone ONNX models (not part of a multi-model GenAI pipeline).
319-
Their f32 inputs are consumed directly.
282+
If the model dtype is already f32, no Cast is needed.
320283

321284
## Cross-references
322285

0 commit comments

Comments
 (0)