Repair all failed typecheck issues, add lint and typecheck to ci/cd

Author: saddlepaddle

.github/workflows/ci.yml

@@ -0,0 +1,81 @@
+name: CI
+
+on:
+  pull_request:
+  push:
+    branches: [main]
+
+jobs:
+  # TODO: Enable lint job after applying lint fixes and setting appropriate warning limits
+  # Will be handled in follow-up PR to avoid blocking CI setup / bloating this PR
+  # lint:
+  #   name: Lint
+  #   runs-on: ubuntu-latest
+
+  #   steps:
+  #     - uses: actions/checkout@v4
+
+  #     - uses: oven-sh/setup-bun@v1
+  #       with:
+  #         bun-version: latest
+
+  #     - name: Cache dependencies
+  #       uses: actions/cache@v4
+  #       with:
+  #         path: |
+  #           ~/.bun/install/cache
+  #         key: ${{ runner.os }}-bun-${{ hashFiles('**/bun.lockb') }}
+
+  #     - name: Install dependencies
+  #       run: bun install --frozen
+
+  #     - name: Run linter
+  #       run: bun lint
+
+  typecheck:
+    name: Typecheck
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: oven-sh/setup-bun@v1
+        with:
+          bun-version: latest
+
+      - name: Cache dependencies
+        uses: actions/cache@v4
+        with:
+          path: |
+            ~/.bun/install/cache
+          key: ${{ runner.os }}-bun-${{ hashFiles('**/bun.lockb') }}
+
+      - name: Install dependencies
+        run: bun install --frozen
+
+      - name: Run type checking
+        run: bun typecheck
+
+  test:
+    name: Unit Test
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: oven-sh/setup-bun@v1
+        with:
+          bun-version: latest
+
+      - name: Cache dependencies
+        uses: actions/cache@v4
+        with:
+          path: |
+            ~/.bun/install/cache
+          key: ${{ runner.os }}-bun-${{ hashFiles('**/bun.lockb') }}
+
+      - name: Install dependencies
+        run: bun install --frozen
+
+      - name: Run tests
+        run: bun test --timeout 30000 --coverage

.github/workflows/unit-test.yml

@@ -8,8 +8,8 @@
         }
     },
     "include": [
-        "src",
-        "test"
+        "script",
+        "server"
     ],
     "exclude": [
         "node_modules"

apps/web/preload/tsconfig.json

@@ -51,6 +51,7 @@ const user0 = {
     createdAt: new Date(),
     updatedAt: new Date(),
     stripeCustomerId: null,
+    githubInstallationId: null,
 } satisfies User;
 
 const project0 = createDefaultProject({
@@ -156,6 +157,7 @@ const context0 = {
     path: 'src/index.ts',
     displayName: 'index.ts',
     content: 'console.log("Hello, world!");',
+    branchId: branch0.id,
 } satisfies MessageContext;
 
 const context1 = {
@@ -165,6 +167,7 @@ const context1 = {
     content: 'console.log("Hello, world!");',
     start: 0,
     end: 10,
+    branchId: branch0.id,
 } satisfies MessageContext;
 
 const contexts = [context0, context1];

apps/web/server/tsup.config.ts

@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "@onlook/typescript/base.json",
   "compilerOptions": {
     "outDir": "dist",
     "rootDir": "src"

packages/db/src/seed/db.ts

@@ -129,8 +129,8 @@ describe('addOidsToAst', () => {
             const ast = getAstFromContent(inputContent);
             if (!ast) throw new Error('Failed to parse input code');
 
-            const globalOids = new Set();
-            const branchOidMap = new Map();
+            const globalOids = new Set<string>();
+            const branchOidMap = new Map<string, string>();
 
             const { ast: astWithIds, modified } = addOidsToAst(
                 ast,

packages/github/tsconfig.json

@@ -1,7 +1,7 @@
 import * as React from 'react';
+import { ChevronLeftIcon, ChevronRightIcon } from '@radix-ui/react-icons';
 import { DayPicker } from 'react-day-picker';
 
-import { ChevronLeftIcon, ChevronRightIcon } from '@radix-ui/react-icons';
 import { cn } from '../utils';
 import { buttonVariants } from './button';
 
@@ -32,7 +32,7 @@ function Calendar({
                 head_cell: 'text-muted-foreground rounded-md w-8 font-normal text-[0.8rem]',
                 row: 'flex w-full mt-2',
                 cell: cn(
-                    'relative p-0 text-center text-sm focus-within:relative focus-within:z-20 [&:has([aria-selected])]:bg-accent [&:has([aria-selected].day-range-end)]:rounded-r-md',
+                    '[&:has([aria-selected])]:bg-accent relative p-0 text-center text-sm focus-within:relative focus-within:z-20 [&:has([aria-selected].day-range-end)]:rounded-r-md',
                     props.mode === 'range'
                         ? '[&:has(>.day-range-end)]:rounded-r-md [&:has(>.day-range-start)]:rounded-l-md first:[&:has([aria-selected])]:rounded-l-md last:[&:has([aria-selected])]:rounded-r-md'
                         : '[&:has([aria-selected])]:rounded-md',
@@ -56,10 +56,10 @@ function Calendar({
                 ...classNames,
             }}
             components={{
-                IconLeft: ({ className, ...props }) => (
+                IconLeft: ({ className, children: _children, ...props }) => (
                     <ChevronLeftIcon className={cn('size-4', className)} {...props} />
                 ),
-                IconRight: ({ className, ...props }) => (
+                IconRight: ({ className, children: _children, ...props }) => (
                     <ChevronRightIcon className={cn('size-4', className)} {...props} />
                 ),
             }}

packages/parser/test/ids.test.ts

@@ -37,7 +37,6 @@ export const restrictEnvAccess = tseslint.config(
 );
 
 export default tseslint.config(
-    // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
     includeIgnoreFile(path.join(import.meta.dirname, '../../.gitignore')),
     {
         ignores: [
@@ -52,15 +51,12 @@ export default tseslint.config(
     {
         files: ['**/*.js', '**/*.ts', '**/*.tsx'],
         plugins: {
-            // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
             import: importPlugin,
-            // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
             prettier: prettierPlugin,
             // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
             onlyWarn,
         },
         extends: [
-            // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
             eslint.configs.recommended,
             ...tseslint.configs.recommended,
             ...tseslint.configs.recommendedTypeChecked,