You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently OGS displays edited moves in the same way as regular moves. If you edit in multiple stones, each edited stone will show up as an individual move in the game tree. This makes it so if you make large edits to the board position or set up a problem on the board, it shows up as a long string of individual moves. This then makes it extremely confusing to navigate the game tree. Other programs will often condense all of these edits into a single icon on the game tree which greatly helps with tree navigation.
My first impression is that this is not a small project, since (a) the parsers/etc. lack the concept of an edit without a move node and (b) any changes here need to be super-well tested (a mistake could break real games).
I do think this is tractable. I just think it's critical to get the testing right.
From the forums:
https://forums.online-go.com/t/condense-edited-position-in-game-tree/50637
The GoEngine can't handle multiple edits in the same move node, so the first step is here in https://github.com/online-go/goban. This should be easy to add tests for, by parsing and/or dumping SGFs.
From the forum discussion:
;
indicates a new game tree nodeB
andW
are moves.;B
and;W
in practice.AB
andAW
indicate edits.;AB[aa]
is a new node with a black edit;AB[aa][ab]
is a new node with two black edits;AB[ff][fg]AW[ef][eg]AB[fh]
is a new node with five editsEDIT: the follow-up to expose this in the analysis interface is online-go/online-go.com#2559.
The text was updated successfully, but these errors were encountered: