Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macros/display: allow variants with #[from] to skip writing a string in their #[error(...)] attr #12

Closed
onkoe opened this issue Jul 8, 2024 · 2 comments
Closed

macros/display: allow variants with #[from] to skip writing a string in their #[error(...)] attr #12

onkoe opened this issue Jul 8, 2024 · 2 comments

Comments

@onkoe
Copy link
Owner

onkoe commented Jul 8, 2024

No description provided.

@onkoe
Copy link
Owner Author

onkoe commented Jul 8, 2024

all #[from] conversions come from Error implementors, so all of them implement Display for us!

when macros/display supports format strings with internal variant fields, it'll be possible to use #[from()] when `#[error("...")] has a string.

@onkoe
Copy link
Owner Author

onkoe commented Aug 21, 2024

completed in e304f68. (use #[error(transparent)])

@onkoe onkoe closed this as completed Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@onkoe