Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Execution Node] Reduce Temporary Linux Page Cache Spikes by 150+ GB RAM #2378

Closed
fxamacker opened this issue May 6, 2022 · 1 comment · Fixed by #2792
Closed

[Execution Node] Reduce Temporary Linux Page Cache Spikes by 150+ GB RAM #2378

fxamacker opened this issue May 6, 2022 · 1 comment · Fixed by #2792
Assignees
Labels

Comments

@fxamacker
Copy link
Member

fxamacker commented May 6, 2022

Problem

As noted in PR #2336, we can further reduce Linux Page Cache use by evicting portions of the file during use rather than waiting to have Linux evict the entire file.

To keep things simple, PR #2336 made Linux evict entire file from page cache after using large (98GB), which successfully prevents Linux eventually hoarding hundreds of GB in its page cache. We can improve upon it by reducing the temporary spikes in Linux Page Cache.

Updates epic #1744

The Proposed Solution

As mentioned in Other Approaches section of PR #2280, it is possible to remove segments of the file while it is used so we can reduce peak Linux page cache usage by 98GB. This can be done without using O_DIRECT so we can avoid edge cases like alignment issues or incompatibility with some filesystems.

Optionally, remove additional files from the Linux page cache such as WAL segment files.

@fxamacker fxamacker self-assigned this May 6, 2022
@fxamacker fxamacker changed the title [Execution Node] Reduce Linux Page Cache Peak Use by 66+ GB RAM [Execution Node] Reduce Linux Page Cache Peak Use by 74+ GB RAM May 16, 2022
@fxamacker fxamacker added the Execution Cadence Execution Team label Jun 16, 2022
@fxamacker fxamacker changed the title [Execution Node] Reduce Linux Page Cache Peak Use by 74+ GB RAM [Execution Node] Reduce Linux Page Cache Peak Use by 98+ GB RAM Jun 16, 2022
@fxamacker fxamacker changed the title [Execution Node] Reduce Linux Page Cache Peak Use by 98+ GB RAM [Execution Node] Reduce Temporary Linux Page Cache Spikes by 98+ GB RAM Jun 16, 2022
@fxamacker fxamacker changed the title [Execution Node] Reduce Temporary Linux Page Cache Spikes by 98+ GB RAM [Execution Node] Reduce Temporary Linux Page Cache Spikes by 150+ GB RAM Aug 23, 2022
@fxamacker
Copy link
Member Author

I'm closing this because:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants
@fxamacker and others