Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support function-purity annotations in CCF #2457

Closed
Tracked by #2157
SupunS opened this issue Apr 20, 2023 · 2 comments · Fixed by #3107
Closed
Tracked by #2157

Support function-purity annotations in CCF #2457

SupunS opened this issue Apr 20, 2023 · 2 comments · Fixed by #3107
Labels
Technical Debt

Comments

@SupunS
Copy link
Member

SupunS commented Apr 20, 2023

Issue to be solved

Function type has a new field called "Purity" in Stable-cadence:

cadence/types.go

Line 1708 in be303b7

Purity FunctionPurity

Serializing/deserializing this new field was added to JSON encoding/decoding when function-purity was added. But now that we also have CCF, this also needs to be supported in the CCF encoder/decoder.

Suggested Solution

No response
@SupunS SupunS mentioned this issue Apr 20, 2023
Merged
6 tasks
@j1010001
Copy link
Member

blocking merging stable Cadence ot master

@fxamacker
Copy link
Member

Updates epic #2157

@fxamacker fxamacker mentioned this issue Aug 21, 2023
Closed
24 tasks
@turbolent turbolent mentioned this issue Jan 29, 2024
Open
@fxamacker fxamacker mentioned this issue Feb 14, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Technical Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for FunctionType.Purity in CCF codec onflow/cadence
3 participants
@SupunS @j1010001 @fxamacker