Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIFs are twice as slow on 120Hz iPad #718

Closed
AMatecki opened this issue Jun 28, 2017 · 6 comments
Closed

GIFs are twice as slow on 120Hz iPad #718

AMatecki opened this issue Jun 28, 2017 · 6 comments

Comments

@AMatecki
Copy link

Check List

Issue Description

What

AnimatedImageView used on 120Hz iPad looks like in a slow motion. I guess Kingfisher assumes 60Hz refresh rate at some point.

Reproduce

  1. Use GIF with AnimatedImageView
  2. Run on 120Hz iPad
@onevcat
Copy link
Owner

onevcat commented Jun 28, 2017

Oh,

Thanks for pointing it out. I'll check it later.

@onevcat
Copy link
Owner

onevcat commented Jun 29, 2017

@AMatecki

It should be something related to CADisplayLink and its duration not matching the update calling.

Can you try to add this to your Info.pllist to see whether it could work?

<key>CADisableMinimumFrameDuration</key> <true/>

I don't have an iPad Pro 10.5 at my hand now, and it seems that the simulator does not support ProMotion.

@onevcat
Copy link
Owner

onevcat commented Jun 29, 2017

@AMatecki It should be fixed in this P-R #719. Could you help to confirm it? Thanks!

@onevcat
Copy link
Owner

onevcat commented Jul 3, 2017

@AMatecki Did you have a chance to try the fix?

@onevcat
Copy link
Owner

onevcat commented Jul 6, 2017

Tried on my device and it seems that be resolved. I am closing this.

@onevcat onevcat closed this as completed Jul 6, 2017
@AMatecki
Copy link
Author

AMatecki commented Jul 18, 2017

Sorry for not responding, I was on holiday. I'll try the fix it soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants