Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I want to specify UIRectCorner on RoundCornerImageProcessor #668

Closed
131e55 opened this issue May 9, 2017 · 3 comments
Closed

I want to specify UIRectCorner on RoundCornerImageProcessor #668

131e55 opened this issue May 9, 2017 · 3 comments
Assignees
@onevcat
Labels
feature in plan

Comments

@131e55
Copy link

131e55 commented May 9, 2017

Issue Description

What

Hi😃 Thank you for developing a very useful library❗

I want to specify UIRectCorner on RoundCornerImageProcessor and Image.kf.image.

For example

let processor = RoundCornerImageProcessor(cornerRadius: 20, targetSize: CGSize(width: 40, height: 40), byRoundingCorners: [.topRight, .bottomRight])

Would you please add this?

Other Comment

I have read the 3.7.1 source code for Image.kf.imgae.
If iOS, just specify a parameter of UIBezierPath.
But if macOS, I dont know how to specify...
@onevcat
Copy link
Owner

onevcat commented May 10, 2017

Good suggestion. I will look at it now to see what we can do.

@onevcat onevcat self-assigned this May 10, 2017
@onevcat onevcat mentioned this issue May 10, 2017
Merged
@onevcat
Copy link
Owner

onevcat commented May 10, 2017

Implemented in #669

@onevcat onevcat closed this as completed May 10, 2017
@131e55
Copy link
Author

131e55 commented May 10, 2017

Thank you very much @onevcat 😍❗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onevcat onevcat

Labels
feature in plan
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@onevcat @131e55