FIX Use correct host on response destination fallback check #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -171,7 +171,7 @@ public function isValid($requestId = null) | |||
| $destination = trim($this->document->documentElement->getAttribute('Destination')); | |||
| if (!empty($destination)) { | |||
| if (strpos($destination, $currentURL) !== 0) { | |||
| $currentURLrouted = OneLogin_Saml2_Utils::getSelfRoutedURLNoQuery(); | |||
| $currentURLrouted = OneLogin_Saml2_Utils::getSelfURLNoQuery(); | |||
There was a problem hiding this comment.
can you rename the $currentURLrouted by $currentURLNoRouted ?
dhensby
force-pushed
the
pulls/proper-destination-check
branch
from
8b6a1a9 to
e1e32a7
Compare
|
I plan to add some improvements on the toolkit in the next weeks, so I will take care of the test of that part. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #151
I'm not sure how I can test this in the current test suite - any advice?