Agency: Ensure a failing pdf file access does not crash application

TYPE: Bugfix
LINK: ogc-1906

src/onegov/agency/models/agency.py

@@ -90,7 +90,10 @@ def pdf_file(self) -> 'StoredFile | None':
 
         """
 
-        return self.pdf.reference.file if self.pdf else None
+        try:
+            return self.pdf.reference.file if self.pdf else None
+        except (OSError, Exception):
+            return None
 
     # FIXME: asymmetric property
     @pdf_file.setter

src/onegov/agency/templates/agency.pt

@@ -29,12 +29,12 @@
 
                 <div tal:condition="request.app.org.meta.report_changes|True" class="borderless-side-panel">
                     <h2 i18n:translate>Changes</h2>
-                        <div class="submit-yours">
-                            <p i18n:translate>The contact form can be used to report changes to incorrect information of the persons or organizations listed. The form is not intended for contacting or sending messages to the respective persons and organizations.</p>
-                            <a href="${request.link(agency.proxy(), 'report-change')}">
-                                <b i18n:translate>Report change</b>
-                            </a>
-                        </div>
+                    <div class="submit-yours">
+                        <p i18n:translate>The contact form can be used to report changes to incorrect information of the persons or organizations listed. The form is not intended for contacting or sending messages to the respective persons and organizations.</p>
+                        <a href="${request.link(agency.proxy(), 'report-change')}">
+                            <b i18n:translate>Report change</b>
+                        </a>
+                    </div>
                 </div>
                 <div tal:condition="agency.coordinates" class="borderless-side-panel">
                     <h2>Karte</h2>

src/onegov/core/widgets.py

@@ -135,7 +135,8 @@ def parse_structure(
                 raise ValidationError('Namespaced attributes are not allowed')
 
         if element.tag not in valid_tags:
-            raise ValidationError("Invalid element '<{}>'".format(element.tag))
+            raise ValidationError(
+                "Invalid element '<{}>'".format(element.tag))  # type:ignore
 
     return xml_tree
 

src/onegov/pdf/pdf.py

@@ -603,7 +603,7 @@ def colorize(
         for element in body:
             if element.tag == 'p':
                 self.p_markup(self.inner_html(element), self.style.paragraph)
-            elif element.tag in 'ol':
+            elif element.tag == 'ol':
                 style = deepcopy(self.style.li)
                 style.leftIndent += self.style.ol.leftIndent
                 items = [

src/onegov/people/models/agency.py

@@ -130,9 +130,10 @@ def ancestors(self) -> 'Iterator[Agency]': ...
     def organigram_file(self) -> 'StoredFile | None':
         """ Returns the file-like content of the organigram. """
 
-        if self.organigram:
-            return self.organigram.reference.file
-        return None
+        try:
+            return self.organigram.reference.file if self.organigram else None
+        except (OSError, Exception):
+            return None
 
     # FIXME: asymmetric property
     @organigram_file.setter