You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We need some way to support opening a bit-vector in read-only fashion. We had a readonly parameter on MmapBitVec::open at one point, but this doesn't work any more because upstream memmap split their base struct into mutable and non-mutable variants without a common trait to unify them (and passing a file created with OpenOptions::new()...write(false)... to a MmapMut initializer doesn't work either).
There are a few possible ways to do this:
implement our own trait on MmapMut and Mmap and store a boxed version of either in the MmapBitVec struct (this may give a perf hit?)
create a separate MmapBitVecReadOnly struct that implements BitVector too and let downstream choose
fork memmap :/
The text was updated successfully, but these errors were encountered:
We need some way to support opening a bit-vector in read-only fashion. We had a
readonly
parameter onMmapBitVec::open
at one point, but this doesn't work any more because upstreammemmap
split their base struct into mutable and non-mutable variants without a common trait to unify them (and passing a file created withOpenOptions::new()...write(false)...
to a MmapMut initializer doesn't work either).There are a few possible ways to do this:
MmapMut
andMmap
and store a boxed version of either in the MmapBitVec struct (this may give a perf hit?)MmapBitVecReadOnly
struct that implements BitVector too and let downstream chooseThe text was updated successfully, but these errors were encountered: