Skip to content

Commit

Permalink
Remove unused registry entries
Browse files Browse the repository at this point in the history
They were misleading to some users and they were of less use, since they used the same registry entries for 32 and 64 bit.

See #242
  • Loading branch information
larskanis committed Nov 26, 2022
1 parent e3be7ae commit bb8cc1a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 13 deletions.
2 changes: 0 additions & 2 deletions recipes/installer-inno/events.iss
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,6 @@ begin
if IsUtf8 then
SetPreviousData(PreviousDataKey, 'Utf8', 'yes');
#endif

SetPreviousData(PreviousDataKey, 'RubyInstallerId', ExpandConstant('{#PackageBaseId}\{#RubyVersion}'));
end;

procedure CurUninstallStepChanged(const CurUninstallStep: TUninstallStep);
Expand Down
11 changes: 0 additions & 11 deletions recipes/installer-inno/rubyinstaller.iss.erb
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#define InstallerHomepage "http://rubyinstaller.org"

#define CurrentYear GetDateTimeString('yyyy', '', '')
#define PackageBaseId <%=q package.packagenamearch %>

#define MsysDir <%=q( with_msys ? package.msysdir : '' )%>
<% if package.rubyver2 < '3.0' %>
Expand Down Expand Up @@ -124,16 +123,6 @@ Root: <%= regroot %>; Subkey: Software\Classes\<%= rubyname %>File\DefaultIcon;
Root: <%= regroot %>; Subkey: Software\Classes\<%= rubyname %>File\shell\open\command; ValueType: string; ValueName: ; ValueData: """{app}\bin\<%= rubyexe %>"" ""%1"" %*"; Check: <%= chkadmin %> and IsAssociated

<% end %>

; RubyInstaller identification for admin+nonadmin
Root: <%= regroot %>; Subkey: Software\RubyInstaller; ValueType: string; ValueName: ; ValueData: ; Flags: uninsdeletevalue uninsdeletekeyifempty; Check: <%= chkadmin %>
Root: <%= regroot %>; Subkey: Software\RubyInstaller\{#PackageBaseId}; ValueType: string; ValueName: ; ValueData: ; Flags: uninsdeletevalue uninsdeletekeyifempty; Check: <%= chkadmin %>
Root: <%= regroot %>; Subkey: Software\RubyInstaller\{#PackageBaseId}\{#RubyVersion}; ValueType: string; ValueName: ; ValueData: ; Flags: uninsdeletekey; Check: <%= chkadmin %>
Root: <%= regroot %>; Subkey: Software\RubyInstaller\{#PackageBaseId}\{#RubyVersion}; ValueType: string; ValueName: InstallLocation ; ValueData: {app}; Check: <%= chkadmin %>
Root: <%= regroot %>; Subkey: Software\RubyInstaller\{#PackageBaseId}\{#RubyVersion}; ValueType: string; ValueName: InstallDate ; ValueData: {code:GetInstallDate}; Check: <%= chkadmin %>
Root: <%= regroot %>; Subkey: Software\RubyInstaller\{#PackageBaseId}\{#RubyVersion}; ValueType: string; ValueName: PackageRelease ; ValueData: {#PackageRelease}; Check: <%= chkadmin %>
Root: <%= regroot %>; Subkey: Software\RubyInstaller\{#PackageBaseId}\{#RubyVersion}; ValueType: string; ValueName: BuildPlatform ; ValueData: {#RubyBuildPlatform}; Check: <%= chkadmin %>
<% end %>

[Icons]
Expand Down

0 comments on commit bb8cc1a

Please sign in to comment.