Skip to content

Commit 1e3286a

Browse files
committed
Append the PATH when running rubydevkit.
1 parent 7f13400 commit 1e3286a

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

lib/ruby_installer/msys2_installation.rb

+3
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,9 @@ def disable_msys_apps(mingwarch=nil)
129129

130130
def msys_apps_envvars_for_cmd
131131
vars = with_msys_install_hint{ msys_apps_envvars }
132+
if (path=vars.delete("PATH")) && !ENV['PATH'].include?(path)
133+
vars['PATH'] = path + ";" + ENV['PATH']
134+
end
132135
vars.map do |key, val|
133136
"#{key}=#{val}"
134137
end.join("\n")

test/test_rubydevkit.rb

+4-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ class TestRubydevkit < Minitest::Test
55
def test_rubydevkit_without_params
66
skip unless File.directory?("C:/msys64")
77

8+
old = ENV['PATH']
9+
ENV['PATH'] += ";c:\\testpath"
810
out = Tempfile.open(%w[test .cmd]) do |fd|
911
fd.write <<-EOT
1012
@call rubydevkit
@@ -16,7 +18,8 @@ def test_rubydevkit_without_params
1618
end
1719

1820
mingw = RUBY_PLATFORM =~ /x64/ ? "MINGW64" : "MINGW32"
19-
assert_match(/PATH: .*;C:\\msys64\\#{mingw}\\bin;C:\\msys64\\usr\\bin/i, out)
21+
assert_match(/PATH: .*;C:\\msys64\\#{mingw}\\bin;C:\\msys64\\usr\\bin.*c:\\testpath$/i, out)
2022
assert_match(/MSYSTEM: #{mingw}/i, out)
23+
ENV['PATH'] = old
2124
end
2225
end

0 commit comments

Comments
 (0)