[L0] Refactor to remove default constructor inits #2260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nrspruit
commented
Oct 28, 2024
nrspruit
commented
- Remove all the default constructor inits to address error prone code changes and force setting of options and flags individually.
- Remove all the default constructor inits to address error prone code changes and force setting of options and flags individually. Signed-off-by: Neil R. Spruit <[email protected]>
github-actions
bot
added
images
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Oct 28, 2024
-pre-commit PR for oneapi-src/unified-runtime#2260 Signed-off-by: Neil R. Spruit <[email protected]>
Contributor
Author
|
repost of #2063 which was incorrectly reverted as causing a bug previously. |
isaacault
approved these changes
Oct 29, 2024
pbalcer
approved these changes
Oct 29, 2024
EwanC
approved these changes
Oct 30, 2024
Contributor
|
intel/llvm#15987 - intel/llvm testing passed |
sarnex
pushed a commit
to intel/llvm
that referenced
this pull request
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.