Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split UR_RESULT_ADAPTER_SPECIFIC_ERROR into two separate ur_result_t, for warnings and for errors #762

Open
hdelan opened this issue Aug 1, 2023 · 0 comments

Comments

@hdelan
Copy link
Contributor

hdelan commented Aug 1, 2023

UR_RESULT_ADAPTER_SPECIFIC_ERROR can be used to emit adapter specific warnings as well as errors.

In CUDA adapter warnings are reported if setErrorMessage is called with UR_SUCCESS followed by a return of UR_RESULT_ADAPTER_SPECIFIC_ERROR. Errors are reported if setErrorMessage is called with UR_RESULT_ADAPTER_SPECIFIC_ERROR followed by a return of UR_RESULT_ADAPTER_SPECIFIC_ERROR. This is unintuitive. It would be nice if we could return either

  • UR_RESULT_ADAPTER_SPECIFIC_ERROR for errors
  • UR_RESULT_ADAPTER_SPECIFIC_WARNING for warnings

And setErrorMessage would not need to take an extra ur_result_t param.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant