Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate the need for urContextSetExtendedDeleter #713

Open
npmiller opened this issue Jul 13, 2023 · 0 comments
Open

Investigate the need for urContextSetExtendedDeleter #713

npmiller opened this issue Jul 13, 2023 · 0 comments
Labels
specification Changes or additions to the specification

Comments

@npmiller
Copy link
Contributor

The goal of this ticket is to gather information on urContextSetExtendedDeleter, and feedback on its uses and whether or not this API is still needed.

As far as I know the only place this is used is in some of the libraries such as oneMKL:

This PR has some explanation on how this scope handle deals with deletion, but doesn't completely explain why it was required in the first place.

Digging into DPC++ this was initially added specifically for the CUDA plugin:

However since then we switched to using the CUDA primary context for the CUDA plugin which removes a lot of the context management complexity:

Therefore it's possible that the oneMKL use-case could now be re-written in a way that doesn't need to extended deleters, and if that's the case and if no other backends needs this API maybe it would make sense to remove it (it might still be used for the HIP adapter, but we probably should align it to the CUDA adapter too).

@kbenzie kbenzie added specification Changes or additions to the specification needs-discussion This needs further discussion labels Jul 13, 2023
@kbenzie kbenzie removed the needs-discussion This needs further discussion label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
specification Changes or additions to the specification
Projects
None yet
Development

No branches or pull requests

2 participants