Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a concrete way for program metadata defines or delete them #441

Open
omarahmed1111 opened this issue Apr 12, 2023 · 0 comments
Open
Labels
compiler Module, program, or kernel issues. pi DPC++ PI requirement specification Changes or additions to the specification

Comments

@omarahmed1111
Copy link
Contributor

Program metadata defines are:

/// Program metadata tags recognized by the PI backends. For kernels the tag
/// must appear after the kernel name.
#define __SYCL_PI_PROGRAM_METADATA_TAG_REQD_WORK_GROUP_SIZE                    \
  "@reqd_work_group_size"
#define __SYCL_PI_PROGRAM_METADATA_GLOBAL_ID_MAPPING "@global_id_mapping"

Those defines seem to only be used inside pi_program::set_metadata() in pi_cuda backend. These values seem to also have been used in the compiler side by llvm/tools/sycl-post-link/sycl-post-link.cpp. So, was wandering, Does those defines had plans for other adapters other than cuda (or have any use case in general) and we should provide them in some way in the spec? or should we delete them?

@omarahmed1111 omarahmed1111 added specification Changes or additions to the specification compiler Module, program, or kernel issues. labels Apr 12, 2023
@kbenzie kbenzie added the pi DPC++ PI requirement label Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler Module, program, or kernel issues. pi DPC++ PI requirement specification Changes or additions to the specification
Projects
None yet
Development

No branches or pull requests

2 participants