Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix urEnqueueKernelLaunchTest.InvalidKernelArgs for CUDA backend #2720

Open
RossBrunton opened this issue Feb 24, 2025 · 0 comments
Open

Fix urEnqueueKernelLaunchTest.InvalidKernelArgs for CUDA backend #2720

RossBrunton opened this issue Feb 24, 2025 · 0 comments
Labels
conformance Conformance test suite issues. cuda CUDA adapter specific issues

Comments

@RossBrunton
Copy link
Contributor

intel/llvm#17068 changed the semantics for urEnqueueKernelLaunch to make validation optional; Implementations may return either INVALID_ARGS or SUCCESS if the arguments are wrong.

However, the Cuda backend in the InvalidKernelArgs test returns UR_RESULT_ERROR_INVALID_VALUE. This is because cuLaunchKernel returns CUDA_ERROR_INVALID_VALUE for the (incorrect) values in the test.

The implementation of urEnqueueKernelLaunch should be updated to either return INVALID_ARGS or SUCCESS. Note that validation is optional, so if the CUDA driver is unable to perform the validation, it is allowed to report a success even if the args are invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conformance Conformance test suite issues. cuda CUDA adapter specific issues
Projects
None yet
Development

No branches or pull requests

1 participant