Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add automatic api validation support #144

Closed
pbalcer opened this issue Dec 19, 2022 · 1 comment
Closed

add automatic api validation support #144

pbalcer opened this issue Dec 19, 2022 · 1 comment
Labels
enhancement New feature or request loader Loader related feature/bug needs-discussion This needs further discussion
Milestone

Comments

@pbalcer
Copy link
Contributor

pbalcer commented Dec 19, 2022

Implement an optional validation API layer that verifies the correctness of UR calls at runtime. In addition to performing basic sanity checks (e.g., checking if provided handles are valid), it should eventually be extended to perform more complex semantic checks, like checking for missing arguments in kernels or tracking object ownership.
This implementation can be modeled after a similar functionality in level-zero.

Overall, we need to:

  1. Implement validation layer infrastructure (controlled with an env variable, UR_VALIDATION=none/basic/complex?)
  2. Analyze the UR API and create a documentation of useful checks that the validation layer could perform.
  3. Implement those checks, starting from high-impact ones.
@pbalcer
Copy link
Contributor Author

pbalcer commented May 17, 2023

Done with #318 #221

@pbalcer pbalcer closed this as completed May 17, 2023
@kbenzie kbenzie added this to the 0.7 milestone Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request loader Loader related feature/bug needs-discussion This needs further discussion
Projects
None yet
Development

No branches or pull requests

2 participants