-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure out and enforce UR's "core" feature set #1267
Comments
I think this comes down to "how big of a deal is it if an adapter doesn't implement x". Looking at sycl I've run into three answers to that question:
For a time during this investigation I thought we might be able to do away with the The outcome of this should be that we communicate which level of optional each feature is to API users and adapter implementers. This will need to be done primarily through the spec and the CTS, although we could make use of other vectors like warning messages once that mechanism matures. I have a plan on how to tackle this for queries: CTS We currently have at least some queries which are realistically optionality mode #3 that currently behave as if they're #2 in some adapters. We will need to go through and fix all of those as part of the testing refactor, each query should be scrutinized before we allow it to return Spec |
During discussion of #537 it came up that we don't have a well defined notion of optionality in the UR spec. A specific example of this is that due to how they're tested, the vast majority of the object handle queries are de-facto optional. This was a deliberate decision, and it's practical because we've always relied heavily on exterior testing rather than the cts for acceptance criteria. Now that we're looking to improve CTS coverage so that we can rely on it for acceptance we should also consider the optionality question in terms of how features are tested and how it's represented in the spec. It was suggested during the discussion that we could analyse the SYCL CTS and e2e tests to get an idea of what our core feature set should look like, and given the e2e tests are what we're trying to match in terms of coverage in the CTS that seems like a sensible place to start.
The text was updated successfully, but these errors were encountered: