Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update oneDNN master from 1.1.2 to 1.2.2 #687

Closed
ChaiBapchya opened this issue Apr 6, 2020 · 4 comments
Closed

Update oneDNN master from 1.1.2 to 1.2.2 #687

ChaiBapchya opened this issue Apr 6, 2020 · 4 comments
Labels
integration Issues with integrating the library into applications

Comments

@ChaiBapchya
Copy link

Summary

apache/mxnet#17884 integrates 3d Conv dilate for CPU [along with other things] from MKLDNN/DNNL/oneDNN into MXNet

However the PR fails due to older version of master.

Observed behavior

Master version 1.1.2

Expected behavior

Master version 1.2.2
@ChaiBapchya ChaiBapchya added the sighting Suspicious library behavior. Should be promoted to a bug when confirmed label Apr 6, 2020
@ChaiBapchya
Copy link
Author

@TaoLv

@vpirogov vpirogov added integration Issues with integrating the library into applications and removed sighting Suspicious library behavior. Should be promoted to a bug when confirmed labels Apr 7, 2020
@wuxun-zhang
Copy link
Contributor

Thank you @ChaiBapchya. We are working on this. The OneDNN version of MXNet is downgraded by one commit (maybe by accident).

@TaoLv
Copy link
Contributor

TaoLv commented Apr 7, 2020

I'm reverting the problematic commit of MXNet to get the right version back. In fact, this is not an issue of oneDNN library. @vpirogov feel free to close. Thanks.

@emfomenk emfomenk closed this as completed Apr 7, 2020
@vpirogov
Copy link
Member

vpirogov commented Apr 7, 2020

Thanks @TaoLv!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
integration Issues with integrating the library into applications
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ChaiBapchya @emfomenk @vpirogov @TaoLv @wuxun-zhang