Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACL] 3D and 4D input support in acl_lowp_matmul_t #2696

Open
alvoron opened this issue Feb 14, 2025 · 1 comment
Open

[ACL] 3D and 4D input support in acl_lowp_matmul_t #2696

alvoron opened this issue Feb 14, 2025 · 1 comment
Labels
enhancement A feature or an optimization request platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64

Comments

@alvoron
Copy link
Contributor

alvoron commented Feb 14, 2025

Currently acl_lowp_matmul_t supports 2D input only:
https://github.com/oneapi-src/oneDNN/blob/main/src/cpu/aarch64/matmul/acl_lowp_matmul.cpp#L109-L112

VDISPATCH_MATMUL(src_d.matches_tag(format_tag::ab) && wei_d.matches_tag(format_tag::ab) && dst_d.matches_tag(format_tag::ab), VERBOSE_UNSUPPORTED_TAG);

Since most models have 3D and 4D MatMul operations, it'd be great to have 3D / 4D support in acl_lowp_matmul_t

cc @milpuz01
@alvoron alvoron added the enhancement A feature or an optimization request label Feb 14, 2025
@shu1chen shu1chen added the platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 label Feb 17, 2025
@theComputeKid
Copy link
Member

cc: @renato-arantes can you take a look into this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A feature or an optimization request platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alvoron @theComputeKid @shu1chen