-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working with the Reorder #1980
Comments
Hi @CodeCrafter18, First of all, primitive descriptor has nothing to do with |
Hi @densamoilov, As I pointed out above in a specific example (ref_sum). The “create” function will be called, but the overridden “create_resource” is not. As a result, the “resource_mapper” is empty at the execution stage. One way to get around this is to create an instance again in "execute" in the case of an “empty” for “resource_mapper”, but this looks like some kind of “crutch”. |
@CodeCrafter18, in the example above you mentioned primitive descriptor and not the primitive, that's why I'm still confused. oneDNN/src/gpu/generic/ref_sum.hpp Line 171 in 8d457a8
|
Let's do it again. We are looking at a specific example: (oneDNN/src/cpu/ref_sum.hpp) The
In this case, the For regular |
If you want to create a resource for your reorder implementation that is used in ref_sum.hpp then you will need to add |
Well, thank you. Why hasn't it been done already? Now the ACL has its own implementation for the Reorder operation and can be called. If it's not difficult, could you provide a modification for test_sum from ctest? And what about the second question, why is there different logic for Reorder Sum and Concat? |
It's a bug in the case when ACL reorder is available. The oneDNN/src/cpu/ref_deconvolution.hpp Lines 407 to 413 in 8d457a8
|
It looks like |
I've made an issue to look into this. We also have work in progress to remove the use for create_resource for the ACL implementations, which I think should fix this issue. |
Hello!
I have a question regarding the usage of reorders.
For example, let's consider ref_sum.hpp.
In this case, the following function will be called:
However, in this scenario,
create_resource(...)
is never called.If I want to write my own Reorder that overrides the
create_resource(...)
function,as it's done in ACL, then I'll get a runtime error when I call ctx.get_resource_mapper()...
How can I work around this problem if my implementation uses
resource_mapper
?Also, I have a question about why the Sum, Reorder, and Concat operations have separate logic, for example, for obtaining the list of implementations?
Thanks.
The text was updated successfully, but these errors were encountered: