Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #83

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Update dependencies #83

merged 1 commit into from
Aug 9, 2018

Conversation

thom4parisot
Copy link
Owner

Minor updates for commander and tape
Major updates for node-rsa and es6-promise

deploy:
provider: npm
email: [email protected]
api_key:
secure: UdhueW/+siuza1tueKlmLfyCxeqXB2Si53mDjz56ZXnW2rDdmBZuzHYE7IFn1u2Le2v+Eu+grGF7v9iGgEuIxMIa0JR+3Q55mZnMKHl+29fkaydq1hJgJH9wIXRu+1wistlnviK+N6fM5zt/H5taVXVV0yO/aAGgOwaFVqb1yrk=
api_key: "$NPM_TOKEN"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the $NPM_TOKEN stored and passed? In travis configuration somewhere?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PavelVanecek yes exactly, instead of being encrypted in the configuration file itself.

@whyisjake
Copy link

FYI, there is a security vulnerability in node-rsa that would be great to get patched.

                                                                                
                       === npm audit security report ===                        
                                                                                
┌──────────────────────────────────────────────────────────────────────────────┐
│                                Manual Review                                 │
│            Some vulnerabilities require your attention to resolve            │
│                                                                              │
│         Visit https://go.npm.me/audit-guide for additional guidance          │
└──────────────────────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Low           │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ lodash                                                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=4.17.5                                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ crx [dev]                                                    │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ crx > node-rsa > lodash                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/577                       │
└───────────────┴──────────────────────────────────────────────────────────────┘

@thom4parisot thom4parisot merged commit 20df2e1 into master Aug 9, 2018
@thom4parisot thom4parisot deleted the feature/update-deps branch August 9, 2018 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants