Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove intermediate copy and use of temporary files #62

Merged
merged 7 commits into from
Sep 22, 2016

Conversation

thom4parisot
Copy link
Owner

@thom4parisot thom4parisot commented Sep 22, 2016

By relying on archiver.glob method, we
can achieve a copy of fine tuned elements contained in the manifest.json folder.

It enables us to:

  1. get rid of temp and wrench
  2. save an initial time and i/o operations to copy the initial files in a temp directory
  3. copy directly files in a streamed way, with a lower memory impact

It also enables us to:

  1. deprecate the undocumented .writeFile() method
  2. deprecate the use of .pack(buffer)

closes #59
refs #57
refs #55
refs #41

@thom4parisot thom4parisot changed the title Remove temporary copy Remove intermediate copy and use of temporary files Sep 22, 2016
@thom4parisot thom4parisot added this to the v3.1.0 milestone Sep 22, 2016
@thom4parisot thom4parisot changed the base branch from v3.1 to master September 22, 2016 12:07
oncletom and others added 5 commits September 22, 2016 13:13
Exclude .pem files and .git dir by default and add unit tests to ensure of the content of the archive.
Sort array as `assert.deepEquals` seems to be picky about the order of things
Even if it implies faking a bit the deprecated method `writeFile` I do not want to spend time testing.
@thom4parisot thom4parisot merged commit 99ff51a into master Sep 22, 2016
@thom4parisot thom4parisot deleted the fix-remove-temp branch September 22, 2016 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove wrench and temp and favour using archive.bulk method
1 participant