Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[security fix] Updated archiver dependency; drops support for node 0.8.x #58

Merged
merged 1 commit into from
Sep 20, 2016

Conversation

PavelVanecek
Copy link
Collaborator

Old archiver comes with old minimatch which suffers of a known vulnerability: https://nodesecurity.io/advisories/118

Updating archiver updates minimatch as well.

Archiver no longer supports node.js 0.8.x which means crx does not support it either. I guess this deserves a major version bump.

@thom4parisot
Copy link
Owner

Well, archiver is used only to let people build their own package so even though there is a vulnerability in minimatch, I do not see any scenario which is likely to expose them?

Unless we only want to prevent them to ReDOS their machine by wrongly configuring crx config – which in this case can be problematic.

I am unsure about the major version bump because it means the current branch would not benefit of the security fix. [email protected] is way behind any support so people have bigger issues if they still run it. Don't you think?

@PavelVanecek
Copy link
Collaborator Author

I'm not aware of any scenario. The biggest pain here is that all our automation tools report possible vulnerability and I need to deal with lots of false positives :)

If I were running a node.js app on 0.8 I would hate to see it stopped working without a major version change of a dependency.

On the other hand, last maintenance update to 0.8 was in July 2014, it seems. Maybe a memo in changelog will do just fine.

@thom4parisot
Copy link
Owner

Agreed :-) Thanks for your feedback and for the PR!

@thom4parisot thom4parisot merged commit e2655cd into thom4parisot:master Sep 20, 2016
@thom4parisot thom4parisot mentioned this pull request Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants