Fix various issues with CLI and creating .pem and .crx files #34
Conversation
| // If a private key file exists, read in the contents | ||
| var keyData; | ||
| if (fs.existsSync(key) ) { | ||
| keyData = fs.readFileSync(key); |
There was a problem hiding this comment.
I'd prefer fs. readFile to be used – use es6-promises – on reject (because `e.code === 'ENOENT'), generate a key.
|
Thanks for your contribution @lepoltj :-) you will need to rebase your PR first. Let me know what you think about my review comments. |
| @@ -3,3 +3,4 @@ test/*.zip | |||
| test/*.xml | |||
| node_modules | |||
| tmp | |||
| .idea | |||
There was a problem hiding this comment.
You can use a global .gitignore setting.
https://help.github.com/articles/ignoring-files/#create-a-global-gitignore
|
Oops, bad rebase. Fixing now. |
…me current working directory for all options. If .pem file is not specified, we will create one automatically (like the docs say) and will continue operation. Added a little more error handling. Refactored some of the read key and generate key code to be more async w/ Promises.
|
All clear. Addressed all comments. Refactored the read/write key code to use Promises. |
|
+1. Bump. Anything holding this up? |
|
👍 @workmanw. Anybody? |
Fix various issues with CLI and creating .pem and .crx files
|
Sorry for the delay guys! Winter break + loads of other things to do. Thanks for having pushed this up :-) |
|
Published as |
If directory is not specified, we'll assume current working directory for all options. If .pem file is not specified, we will create one automatically (like the docs say) and will continue operation. Added a little more error handling.
Fixes
#33
#31