Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use temp module #30

Merged
merged 1 commit into from
Dec 7, 2014
Merged

Conversation

joscha
Copy link
Collaborator

@joscha joscha commented Nov 30, 2014

this makes use of a temp module to automatically generate a temporary directory and remove any files created when the process terminates

@thom4parisot
Copy link
Owner

Oh lovely addition!

Should not cleanup() be called at some point?

@joscha
Copy link
Collaborator Author

joscha commented Dec 7, 2014

that's what temp.track(); is supposed to do automatically - did you see it not working?

@thom4parisot
Copy link
Owner

Oh no my bad, I have not read that it was called automatically on process.exit.

Sounds good to me 👍

thom4parisot pushed a commit that referenced this pull request Dec 7, 2014
@thom4parisot thom4parisot merged commit 7a1ed7b into thom4parisot:master Dec 7, 2014
@thom4parisot thom4parisot modified the milestone: 3.0.0 Dec 7, 2014
okuryu added a commit to okuryu/crx that referenced this pull request Dec 23, 2014
The `destory()` method seems to removed in thom4parisot#30.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants