generatePublicKey promise and generateAppId state

[joscha]

• add hint to generatePublicKey method about callback parameter (it now returns a promise and does not take a callback any more as it used to)
• generateAppId should take param in favor to local state

[thom4parisot]

👍

Should we remove the internal publicKey variable? It can be generated at anytime now, and synchronously so it does not matter much to store it in the current instance of crx.

What do you think?

[joscha]

@oncletom yes, I think removing state is a good idea - wasn't sure if there was some reason to keep it except backwards compat.

[thom4parisot]

Nah it's better to clean that up and to reflect that through another major bump version again, when all the other PRs get merged as well.

[joscha]

Okay, so how about I rebase this PR and we open a second one to completely remove the this.publicKey state?

[thom4parisot]

I've seen you have rebased that's good!

Okay for an extra PR to remove the publicKey from the internal state as well 👍

[joscha]

👍