fixes minor code problems, such as missing semicolons, etc. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
joscha
commented
Nov 30, 2014
joscha
commented
- a few forgottons semicolons
- a few forgotten "new" invocations
- globals definition for JSHint
| @@ -1,3 +1,4 @@ | |||
| /* global require, process, Buffer, module */ | |||
There was a problem hiding this comment.
Yes, it tells JSHint that these symbols exist in the global namespace
There was a problem hiding this comment.
OK I see. Thanks 👍
I will add a .jshintrc with a node flag set to true once I merge this PR :-)
There was a problem hiding this comment.
Cool, as the branch is on this repo, you can also just reuse it and add the .jshintrc in here and close it together.
There was a problem hiding this comment.
oops, just saw, the branch needs rebasing before anyway...
|
@oncletom rebased and added JSHint rules |
thom4parisot
pushed a commit
that referenced
this pull request
Dec 18, 2014
fixes minor code problems, such as missing semicolons, etc.
|
Thanks @joscha 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.