Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed bufferstream dependency #16

Merged
merged 1 commit into from
Apr 14, 2014
Merged

Conversation

christian-bromann
Copy link
Contributor

reason:

  • installation breaks on Windows systems (see camme/webdriverjs/issues/189) because bufferstream (to be exact buffertools) requires python
  • it is obsolete

- installation breaks on Windows systems
- is obsolete
jed added a commit that referenced this pull request Apr 14, 2014
removed bufferstream dependency
@jed jed merged commit ea5538a into thom4parisot:master Apr 14, 2014
@jed
Copy link
Contributor

jed commented Apr 14, 2014

thanks, @christian-bromann!

@matthewgertner
Copy link

For me this breaks .crx creation on Windows. It doesn't look like the finish event is ever fired by Archiver. Where exactly is this event fired in the Archiver sources?

@christian-bromann
Copy link
Contributor Author

here:

Finalizes the instance. You should listen for the end/close/finish of the destination stream to properly detect completion.

@matthewgertner
Copy link

Yeah I saw that but it's not being fire in finalize for us. Is the actual finish event fired in zip-stream somewhere? I trawled around the code a bit but didn't see it. For now I've reverted back to crx 0.4.1, which works fine.

I should mention that we are building a .crx file using grunt-crx on Windows.

@vsa
Copy link

vsa commented Jul 2, 2014

Same here. Creates a tmp directory with all files, then aborts while attempting to zip. Also on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants