Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CLI script to src folder #103

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Move CLI script to src folder #103

merged 1 commit into from
Apr 5, 2019

Conversation

arkon
Copy link
Collaborator

@arkon arkon commented Apr 5, 2019

Moving everything to the same folder, to hopefully make future TS build processes (for #82) slightly more sensible.

ahwayakchih
ahwayakchih requested changes Apr 5, 2019
View reviewed changes
Copy link
Collaborator

@ahwayakchih ahwayakchih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • src/cli.js is missing: forgot to stage it for commit? happens to me from time to time :).
  • src/crx.js is removed: i'm guessing it was a mistake? If not, what was the reason? Without its code module is not working at all :).

@arkon
Copy link
Collaborator Author

arkon commented Apr 5, 2019

Whoops, indeed forgot to stage the renamed files.

@arkon arkon merged commit 045faa8 into thom4parisot:master Apr 5, 2019
@arkon arkon deleted the mv-bin branch April 5, 2019 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahwayakchih ahwayakchih ahwayakchih approved these changes

@thom4parisot thom4parisot Awaiting requested review from thom4parisot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arkon @ahwayakchih @echeung-amzn