Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CRX2 logic to separate file #100

Merged
merged 2 commits into from
Apr 2, 2019
Merged

Move CRX2 logic to separate file #100

merged 2 commits into from
Apr 2, 2019

Conversation

arkon
Copy link
Collaborator

@arkon arkon commented Mar 30, 2019

As mentioned in #98.

@ahwayakchih
Copy link
Collaborator

@arkon ninja'ed me - wanted to work on this today. Oh well, more free time for me, thanks :D!

src/crx.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@ahwayakchih ahwayakchih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added one comment, but otherwise it looks great.

@ahwayakchih ahwayakchih merged commit 1abfa82 into thom4parisot:master Apr 2, 2019
@arkon arkon deleted the mv-crx2-logic branch April 3, 2019 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants