Skip to content

Commit 4df2936

Browse files
committed
test: improve invalid ContentItemSelectionRequest test(s)
1 parent 0331111 commit 4df2936

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

test/Provider.coffee

+9-4
Original file line numberDiff line numberDiff line change
@@ -187,9 +187,14 @@ describe 'LTI.Provider', () ->
187187
valid.should.equal true
188188
done()
189189

190-
it "should return false if lti_message_type is ContentItemSelectionRequest and there are invalid fields", (done) =>
191-
invalidFields = [ 'resource_link_id', 'resource_link_title','resource_link_description','launch_presentation_return_url', 'lis_result_sourcedid' ]
192-
for invalidField in invalidFields
190+
[
191+
'resource_link_id',
192+
'resource_link_title',
193+
'resource_link_description',
194+
'launch_presentation_return_url',
195+
'lis_result_sourcedid'
196+
].forEach (invalidField) =>
197+
it "should return false if lti_message_type is ContentItemSelectionRequest and there is a \"#{invalidField}\" field", (done) =>
193198
req =
194199
url: '/test'
195200
method: 'POST'
@@ -213,7 +218,7 @@ describe 'LTI.Provider', () ->
213218
@provider.valid_request req, (err, valid) ->
214219
should.exist err
215220
valid.should.equal false
216-
done()
221+
done()
217222

218223
it 'should special case and deduplicate Canvas requests', (done) =>
219224
req =

0 commit comments

Comments
 (0)