Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structured Configs: Support inheriting from Dict and List. #134

Closed
omry opened this issue Jan 25, 2020 · 1 comment
Closed

Structured Configs: Support inheriting from Dict and List. #134

omry opened this issue Jan 25, 2020 · 1 comment
Milestone
OmegaConf 2.0.0

Comments

@omry
Copy link
Owner

omry commented Jan 25, 2020 

@dataclass
class Params(Dict[str, Any]):
    pass

PluginConfig = OmegaConf.create({"class": StringNode(MISSING), "params": Params()})
  1. This should not be strict.
  2. The value should be interpreted as a non strict Structured config.
@omry omry added this to the OmegaConf 2.0.0 milestone Jan 25, 2020
@omry
Copy link
Owner Author

omry commented Jan 29, 2020

done for Dict. List is delayed until there is a use case.

@omry omry closed this as completed Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
OmegaConf 2.0.0
Development

No branches or pull requests
1 participant
@omry