Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Use Eslint in CI and let Eslint fix issues automatically and push those changes directly via CI in repo. #95

Closed
Raboro opened this issue Jul 2, 2023 · 0 comments · Fixed by #161
Assignees

Comments

@Raboro
Copy link

Raboro commented Jul 2, 2023

There is already a Eslint configuration file: .eslintrc. It would be nice to use the linter to have a good code style. To not always run it yourself it could be integrated into the CI workflow. But then you must fix the issues by yourself and the build fails. It would be better to let Eslint fix the issues automatically in CI and push those changes directly back into the repo. Full automation.

If this sounds nice a couple of changes must be done. Two scripts in package.json must be added. One to fix the issues and one check code style after the fix to validate that there are no issues left. Also integration into CI (both .yml files). And a change to the repo settings. To let the Action Bot directly push into the repo, this must be enabled in the settings: Actions > General > Workflow permissions to Read and Write permissions:
image

@sywhb sywhb self-assigned this Nov 14, 2023
@sywhb sywhb closed this as completed Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants