We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently the bridge could send the same transactions several times if the database is not updated properly.
The following changes could be introduced:
Deposit()
deposit()
For Foreign chain it is necessary to check that
depositsSigned(sha3(ValidatorAddress, sha3(HomeDepositSender, Value, HomeTransactionHash)))
returns false and invoke deposit() in this case only.
false
Withdraw()
submitSignature()
messagesSigned(sha3(ValidatorAddress, sha3(message)))
returns false and invoke submitSignature() in this case only.
CollectedSignatures()
withdraw()
For Home chain it is necessary to check that
withdraws(ForeignTransactionHash)
returns false and invoke withdraw() in this case only.
The text was updated successfully, but these errors were encountered:
very good explanation one more stategy to this is to run estimateGas it should succeed
estimateGas
Sorry, something went wrong.
my expectation is that estimateGas will require more time to check tx. But it needs to be measured first of course.
No branches or pull requests
Currently the bridge could send the same transactions several times if the database is not updated properly.
The following changes could be introduced:
Deposit()
event and avoid invocation ofdeposit()
several times for the same origin transaction:For Foreign chain it is necessary to check that
returns
false
and invokedeposit()
in this case only.Withdraw()
event on the Foreign side and avoid invocation ofsubmitSignature()
several times for the same 'message'For Foreign chain it is necessary to check that
returns
false
and invokesubmitSignature()
in this case only.CollectedSignatures()
event on the Foreign side and avoid invocation ofwithdraw()
several times for the the same origin transactionFor Home chain it is necessary to check that
returns
false
and invokewithdraw()
in this case only.The text was updated successfully, but these errors were encountered: