add information about block retrieval #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdobacz
reviewed
Jan 27, 2020
| @@ -52,7 +52,8 @@ event BlockSubmitted( | |||
|
|
|||
| > ***Note**: For more information about parameter types, return types, valid values, and so on, see the [Plasma Contract API documentation](../contracts/BlockController.md#submitblock).* | |||
|
|
|||
|
|
|||
| # Block retrieval | |||
| To learn what blocks need to be retrieved during sync, compute block numbers by iterating every `childBlockInterval` from `0 + childBlockInterval` up to `nextChildBlock - childBlockInterval`, inclusive. Next, learn their commited hash values by reading `blocks` mapping. | |||
There was a problem hiding this comment.
a couple of points:
- how to get
childBlockIntervalandnextChildBlock commited hash-> submitted root of the block Merkle tree (consistent with# Block submission)reading...mapping-> I think this deserves listing out as a contract call, similar to this for example
pdobacz
reviewed
Jan 27, 2020
kevsul
previously approved these changes
Feb 11, 2020
|
Sorry , I had missed this originally. |
|
Committed Kevin's suggestion. Please re-review. Need two confirmations to merge. |
paulperegud
force-pushed
the
paulperegud-patch-1
branch
from
697c280
to
6d2f02d
Compare
kevsul
previously approved these changes
Feb 17, 2020
pdobacz
previously approved these changes
Feb 18, 2020
paulperegud
force-pushed
the
paulperegud-patch-1
branch
from
6d2f02d
to
1dc8710
Compare
kevsul
approved these changes
Feb 20, 2020
pnowosie
reviewed
Feb 20, 2020
| @@ -52,7 +52,8 @@ event BlockSubmitted( | |||
|
|
|||
| > ***Note**: For more information about parameter types, return types, valid values, and so on, see the [Plasma Contract API documentation](../contracts/BlockController.md#submitblock).* | |||
|
|
|||
|
|
|||
| # Block retrieval | |||
| To learn what blocks need to be retrieved during sync, read `PlasmaFramework.nextChildBlock()` and `PlasmaFramework.childBlockInterval()`. Compute the block numbers by iterating every `childBlockInterval` from `0 + childBlockInterval` up to `nextChildBlock - childBlockInterval`, inclusive. Next, read the Merkle tree root of each block by calling `PlasmaFramework.blocks(blknum)`. | |||
There was a problem hiding this comment.
...Compute the block numbers by iterating isn't very clear for me. I guess we need to put some math at it.
Block numbers are elements of arithmetic progression with a common difference of childBlockInterval, starting from ...
pnowosie
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.