Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review information emitted in contract events #659

Open
kevsul opened this issue Jul 20, 2020 · 2 comments
Open

Review information emitted in contract events #659

kevsul opened this issue Jul 20, 2020 · 2 comments

Comments

@kevsul
Copy link
Contributor

kevsul commented Jul 20, 2020

Let's review the information contained in the events emitted by the contracts, especially the exit-related events as described here: #576

We've discovered that relying on transaction calldata is a bad idea https://github.com/omgnetwork/private-issues/issues/64

Also, this issue is related #573

@InoMurko
Copy link
Contributor

There's quite a few issues related to Events now. Perhaps we should have a larger scope for all these

#573

#576

#129

@InoMurko
Copy link
Contributor

InoMurko commented Aug 5, 2020

Another one not particulary useful is:

emit ChildChainActivated(authority);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants