Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethereumex http client responses are underspecified #1587

Closed
pnowosie opened this issue Jun 17, 2020 · 0 comments · Fixed by #1782
Closed

Ethereumex http client responses are underspecified #1587

pnowosie opened this issue Jun 17, 2020 · 0 comments · Fixed by #1782
Assignees

Comments

@pnowosie
Copy link
Contributor

opsgenie: 588

We're matching response from Ethereumex in our Eth.Client.node_ready/0 and got {:error, :closed} which is not expected in the case statement.

Consider to extend match to {:error, _} -> {:error, :geth_not_listening}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants