Added support for multiple bluetooth devices #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omaraflak
reviewed
Aug 11, 2019
| @@ -47,7 +47,7 @@ | |||
| private DiscoveryCallback discoveryCallback; | |||
| private BluetoothCallback bluetoothCallback; | |||
|
|
|||
| private ReceiveThread receiveThread; | |||
| private ArrayList<ReceiveThread> receiveThreads = new ArrayList<>(); | |||
There was a problem hiding this comment.
Prefer the use of List here :
List<ReceiveThread> receiveThreads;and initialize it with the other variables in the initialize() method :
receiveThreads = new ArrayList<>();
omaraflak
reviewed
Aug 11, 2019
| */ | ||
| public void disconnect() { | ||
| for (ReceiveThread receiveThread: receiveThreads) { |
There was a problem hiding this comment.
We want to able to control each socket separately. We should not disconnect every socket.
There was a problem hiding this comment.
Or you should rename the method disconnectAll()
omaraflak
reviewed
Aug 11, 2019
| @@ -315,11 +336,33 @@ public boolean isConnected(){ | |||
| } | |||
|
|
|||
| /** | |||
| * Send string message to the connected device. | |||
| * Send string message to all the connected devices. | |||
| * @param msg String message. | |||
| * @param charset Charset used to encode the String. Default charset is UTF-8. | |||
| */ | |||
| public void send(String msg, String charset){ | |||
There was a problem hiding this comment.
Same here, can you rename it to sendToAll() ?
omaraflak
reviewed
Aug 11, 2019
| @@ -478,7 +513,8 @@ public void run() { | |||
| try { | |||
| socket.connect(); | |||
| connected = true; | |||
| receiveThread = new ReceiveThread(socket, device); | |||
| ReceiveThread receiveThread = new ReceiveThread(socket, device); | |||
There was a problem hiding this comment.
Also, we should be able to differentiate messages from callbacks. We should know which socket triggered which callback.
There was a problem hiding this comment.
I need it. Do you have update for this?
bluetooth.setDeviceCallback(new DeviceCallback() {
@Override
public void onMessage(BluetoothDevice device, byte[] message) {
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the changes that would resolve #42, adding in support for multiple Bluetooth connections. I have been unable to fully test the functionality yet, but will be able to do so in the next week as I will be around the hardware then. If you have any suggestions or ideas for additional changes, let me know!