Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow exception handling during DEBUG mode #1118

Open
bhch opened this issue Jan 2, 2019 · 0 comments
Open

Allow exception handling during DEBUG mode #1118

bhch opened this issue Jan 2, 2019 · 0 comments

Comments

@bhch
Copy link

bhch commented Jan 2, 2019

Exceptions should be handled even when DEBUG = True.

Consider the NotAllowedToDisconnect exception. This exception is very closely related to the application UX. It is an expected exception. What I mean is, as a developer, I know that if a user tries to disconnect without providing a password, this exception will be raised. So I'll have to write appropriate code to prepare for that case, like to redirect user to a certain page or ask them to set a password.

This is part of the development process. But right now, I have to turn off DEBUG mode or override SocialAuthExceptionMiddleware.raise_exception to write code for this scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant