Skip to content

Commit 39f112f

Browse files
committed
stop returning empty dict when request has zero content-length
1 parent f43b9ae commit 39f112f

File tree

2 files changed

+17
-17
lines changed

2 files changed

+17
-17
lines changed

pyfcm/__meta__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
__summary__ = 'Python client for FCM - Firebase Cloud Messaging (Android & iOS)..'
66
__url__ = 'https://github.com/olucurious/pyfcm'
77

8-
__version__ = '1.3.1'
8+
__version__ = '1.3.2'
99

1010
__install_requires__ = ['requests', 'requests-toolbelt']
1111

pyfcm/baseapi.py

+16-16
Original file line numberDiff line numberDiff line change
@@ -230,23 +230,23 @@ def parse_responses(self):
230230
Returns a python dict of multicast_id(long), success(int), failure(int), canonical_ids(int), results(list)
231231
"""
232232
if 'content-length' in response.headers and int(response.headers['content-length']) <= 0:
233-
return {}
234-
235-
parsed_response = response.json()
233+
response_list.append({})
234+
else:
235+
parsed_response = response.json()
236236

237-
multicast_id = parsed_response.get('multicast_id', None)
238-
success = parsed_response.get('success', 0)
239-
failure = parsed_response.get('failure', 0)
240-
canonical_ids = parsed_response.get('canonical_ids', 0)
241-
results = parsed_response.get('results', [])
242-
message_id = parsed_response.get('message_id', None) # for topic messages
243-
if message_id:
244-
success = 1
245-
response_list.append({'multicast_id': multicast_id,
246-
'success': success,
247-
'failure': failure,
248-
'canonical_ids': canonical_ids,
249-
'results': results})
237+
multicast_id = parsed_response.get('multicast_id', None)
238+
success = parsed_response.get('success', 0)
239+
failure = parsed_response.get('failure', 0)
240+
canonical_ids = parsed_response.get('canonical_ids', 0)
241+
results = parsed_response.get('results', [])
242+
message_id = parsed_response.get('message_id', None) # for topic messages
243+
if message_id:
244+
success = 1
245+
response_list.append({'multicast_id': multicast_id,
246+
'success': success,
247+
'failure': failure,
248+
'canonical_ids': canonical_ids,
249+
'results': results})
250250
elif response.status_code == 401:
251251
raise AuthenticationError("There was an error authenticating the sender account")
252252
elif response.status_code == 400:

0 commit comments

Comments
 (0)