Fix: Long paths not workin in Windows (paths equal or greater than 260 characters)

Author: ollm

CHANGELOG.md

@@ -23,7 +23,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - Optimized index loading and folder navigation [`0e6000f`](https://github.com/ollm/OpenComic/commit/0e6000f00e445de98eab7cdfbf72ee9b0016bf26)
 - Error extracting files with 7zip if the file name contained UTF8 characters [`27c863b`](https://github.com/ollm/OpenComic/commit/27c863b6a9abd434e8855216100e5f8087ed1e73)
 - Fullscreen error [`d72813a`](https://github.com/ollm/OpenComic/commit/d72813abbb0320a94bee5b2881c2bfcd1f2084cf)
-- Files shared over a network in Windows do not open
+- Files shared over a network in Windows do not open [`bab197f`](https://github.com/ollm/OpenComic/commit/bab197fa11f89ae07a707e4f42ea144a5416f25f)
+- Long paths not workin in Windows (paths equal or greater than 260 characters)
 
 ## [v1.2.0](https://github.com/ollm/OpenComic/releases/tag/v1.2.0) (29-03-2024)
 

package.json

@@ -94,6 +94,7 @@
 		"sanitize-html": "^2.13.0",
 		"sha1": "^1.1.1",
 		"sharp": "^0.33.3",
+		"short-windows-path": "^1.0.0",
 		"shosho": "^1.4.3",
 		"ssh2-sftp-client": "^10.0.3",
 		"tar-fs": "^3.0.6",

scripts/image.js

@@ -4,6 +4,8 @@ async function resize(fromImage, toImage, config = {})
 {
 	if(sharp === false) sharp = require('sharp');
 
+	fromImage = shortWindowsPath.generateSync(fromImage);
+
 	config = {...{
 		width: 200,
 		fit: sharp.fit.inside,
@@ -74,6 +76,8 @@ async function resizeToCanvas(fromImage, config = {})
 {
 	if(sharp === false) sharp = require('sharp');
 
+	fromImage = shortWindowsPath.generateSync(fromImage);
+
 	config = {...{
 		// background: 'white',
 		kernel: 'lanczos3',
@@ -113,6 +117,8 @@ async function resizeToBlob(fromImage, config = {})
 {
 	if(sharp === false) sharp = require('sharp');
 
+	fromImage = shortWindowsPath.generateSync(fromImage);
+
 	config = {...{
 		// background: 'white',
 		kernel: 'lanczos3',
@@ -200,6 +206,8 @@ async function convertToPng(fromImage, toImage, config = {})
 {
 	if(sharp === false) sharp = require('sharp');
 
+	fromImage = shortWindowsPath.generateSync(fromImage);
+
 	config = {...{
 		// background: 'white',
 		kernel: 'nearest',
@@ -226,6 +234,8 @@ async function convertToWebp(fromImage, toImage, config = {})
 {
 	if(sharp === false) sharp = require('sharp');
 
+	fromImage = shortWindowsPath.generateSync(fromImage);
+
 	config = {...{
 		// background: 'white',
 		kernel: 'nearest',

scripts/opencomic.js

@@ -83,6 +83,7 @@ const electron = require('electron'),
 	sha1 = require('sha1'),
 	p = require('path'),
 	isEqual = require('lodash.isequal'),
+	shortWindowsPath = require('short-windows-path'),
 	$ = require('jquery');
 
 require('jquery-bez');
@@ -1145,6 +1146,12 @@ hb.registerHelper('encodeSrcURI', function(string) {
 
 });
 
+hb.registerHelper('shortWindowsPath', function(string) {
+
+	return shortWindowsPath.generateSync(string);
+
+});
+
 hb.registerHelper('normalizeNumber', function(value, decimals) {
 
 	value = String(value);

scripts/reading/render.js

@@ -441,7 +441,7 @@ async function render(index, _scale = false, magnifyingGlass = false)
 			}
 			else
 			{
-				img.src = encodeSrcURI(img.dataset.src);
+				img.src = encodeSrcURI(shortWindowsPath.generateSync(img.dataset.src));
 				img.classList.remove('blobRendered', 'blobRender');
 				img.style.imageRendering = '';
 			}

templates/reading.content.right.html

@@ -42,7 +42,7 @@
 						{{else if ebook}}
 						<!-- <iframe> -->
 						{{else}}
-						<img src="{{chain 'encodeSrcURI' 'invertBackslash' image}}" data-src="{{htmlQuote image}}" data-path="{{htmlQuote path}}" data-index="{{index}}">
+						<img src="{{chain 'shortWindowsPath' 'encodeSrcURI' 'invertBackslash' image}}" data-src="{{htmlQuote image}}" data-path="{{htmlQuote path}}" data-index="{{index}}">
 						{{/if}}
 					</oc-img>
 				</div>

templates/reading.content.right.images.html

@@ -20,7 +20,7 @@
 				{{else if ebook}}
 				<!-- <iframe> -->
 				{{else}}
-				<img src="{{chain 'encodeSrcURI' 'invertBackslash' image}}" data-src="{{htmlQuote image}}" data-path="{{htmlQuote path}}" data-index="{{index}}">
+				<img src="{{chain 'shortWindowsPath' 'encodeSrcURI' 'invertBackslash' image}}" data-src="{{htmlQuote image}}" data-path="{{htmlQuote path}}" data-index="{{index}}">
 				{{/if}}
 			</oc-img>
 			{{/if}}