-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SetNoWhiteSpace and SetTablePadding options to have more kubectl like output #144
Conversation
@olekukonko @mattn can you please review. |
@shreddedbacon looks good. do we need to make this kubernetes specific? Can we just keep it generic with something like "table padding" option? |
I guess it doesn't have to be kube specific, but all the requests for this sort of feature were to be more kubectl like, which was also what I was after. Happy to rename it to something else if you have an idea, these are the two options added, and they sort of need to work together. You can't really use it outside of what is in the example I posted.
Ideas for renaming? |
Yeah I also want for the same reason but this library shouldn't be concerned with specific use cases in that it has knowledge of them, rather it should implement capabilities that enable them. I think |
Sweet, thanks @woodcockjosh I've made adjustments like suggested. |
Looks good. @woodcockjosh thought? |
Looks great! |
Thank you |
When release? |
🎉 Awesome, thank you! |
I'll tag soon. |
Description
This adds the ability to output table data much more like kubectl by removing the white space at the start of rows. It also introduces a padding option so you can choose either spaces or tab as the padding between columns
An example has been added to the README, but is posted here for visibility
A test has also been written
Example
ExampleSet KubeFormat option
Output
Closes
This PR should close #129