Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable white spaces in row start #130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alok87
Copy link

@alok87 alok87 commented May 14, 2019

#129

Before

$ cmdctl get products heimdall
  NAME      REPO
  heimdall  practo/heimdall

After

table.SetTrimRowStart(true)
$ cmdctl get products heimdall
NAME     REPO
heimdall practo/heimdall

kubectl prints like this (some users would want to keep the same convention)

@olekukonko
Copy link
Owner

@mattn what do you think?

@mattn
Copy link
Collaborator

mattn commented Jun 7, 2019

@alok87 please add test?

@olekukonko
Copy link
Owner

@mattn looking at this critically, does it require a test?

@mattn
Copy link
Collaborator

mattn commented Jun 7, 2019

This is not a bug fix. So I hope to add test to not break this feature.

@ppwfx
Copy link

ppwfx commented Jul 24, 2019

looking forward for it getting merged

@woodcockjosh
Copy link

@olekukonko Please merge and release this

@woodcockjosh
Copy link

woodcockjosh commented Sep 29, 2019

@alok87 I think this should just trim the row start and the row end. Can you please update to just be SetTablePadding(false) otherwise there will be spaces at the end still which matters when using awk

@woodcockjosh
Copy link

woodcockjosh commented Oct 7, 2019

@alok87 Are you still planning on completing this? If not I can open a PR to resolve #129

@mattn
Copy link
Collaborator

mattn commented Oct 7, 2019

Yes, but waiting for test.

@alok87
Copy link
Author

alok87 commented Oct 8, 2019

@woodcockjosh please go ahead and give PRs :)

@woodcockjosh
Copy link

I will try to work on this tomorrow

@shreddedbacon
Copy link
Contributor

I've raised PR #144 which includes a test

@olekukonko
Copy link
Owner

@mattn we need to attend to all pending PR

@mattn
Copy link
Collaborator

mattn commented Oct 21, 2020

Please rebase from master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants