Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Theme has many PHPCS warnings #907

Closed
Leland opened this issue Oct 18, 2016 · 0 comments · Fixed by #908
Closed

Theme has many PHPCS warnings #907

Leland opened this issue Oct 18, 2016 · 0 comments · Fixed by #908

Comments

@Leland
Copy link
Contributor

Leland commented Oct 18, 2016

The master branch is currently seeing quite a few warnings when the standard WP PHPCS ruleset is run against it. Many of these can be addressed, and in so doing will help standardize the coding style used throughout the project – in addition to more closely adhering to the WordPress PHP Coding Standards.

How can this bug be reproduced?

  1. Install theme and the repository's oneliner for PHPCS
  2. Run npm run phpcs

What did you expect to happen?
There to be few, or no, warnings.

What happened instead?
There were quite a few warnings.

Include Test Case
You can see the output of PHPCS when following the steps above on this Gist: https://gist.github.com/Leland/13958455550d8e9c234fc688d7e97c33

@Leland Leland changed the title Theme fails PHPCS (Codesniffer) Theme has many PHPCS warnings Oct 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant