Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

foundationpress_fixed_img_caption_shortcode is being ignored #383

Closed
zanetaylor opened this issue Jul 16, 2015 · 2 comments
Closed

foundationpress_fixed_img_caption_shortcode is being ignored #383

zanetaylor opened this issue Jul 16, 2015 · 2 comments

Comments

@zanetaylor
Copy link

The shortcode in library/cleanup.php to replace the default WP caption HTML with <figure> and <figcaption> seems to be completely ignored by WordPress 4.2.2.

@Aetles
Copy link
Contributor

Aetles commented Jul 16, 2015

I think the whole library/cleanup.php could use an overview. I'm not sure how many of the functions there are still needed, I usually end up remove some of them because they caused issues for me. Most of the code there is still the same as the code was in Reverie 4 of which I'm pretty sure FoundationPress was a fork of, even though it does not say so anywhere.

@olefredrik
Copy link
Owner

You're right. The image cleanup functions was quite a mess, to be honest. Have wiped it out and replaced it with a better solution, adopted from Brian Gottie. Check this pull request for details #384.

The demo page is now updated with a working example of an image with a caption.
http://foundationpress.olefredrik.com/post-with-an-image-and-caption/

Feel free to tweak it further and add in <figure>, <figcaption> tags and whatnot. I'm always open to look at your pull requests if you want to contribute :)

Cheers,
Ole Fredrik

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants